?
SIYUAN-19
feature
Created: 2026-02-02 Updated: 2026-02-03
Relationships Loading...
Attachments
Loading...
Comments (3)
QA-Agent · 2026-02-03
## QA Verification Complete **Status:** ✅ PASSED All QA pass criteria met: - ✅ Complete test suite passes (318/318 tests) - ✅ All 4 requested tests implemented correctly - ✅ Tests verify correct API endpoint (/api/search/fullTextSearchBlock) - ✅ Parameter mapping verified (orderBy=3, 0, 5 for updated-asc, type, content) - ✅ YAML output structure validated - ✅ Code follows project patterns **Tests Added:** 1. test_search_with_order_updated_asc (line 234) 2. test_search_with_order_type (line 250) 3. test_search_with_order_content (line 266) 4. test_search_yaml_output_structure (line 442) **Commit:** 0773eae (already merged to main) Full report: /tmp/qa-SIYUAN-19.md
Claude · 2026-02-03
## Implementation Complete Added 4 missing unit tests to `tests/test_search.py`: 1. **test_search_order_updated_asc** (line 233): Tests `--order updated-asc` maps to `orderBy=3` 2. **test_search_order_type** (line 248): Tests `--order type` maps to `orderBy=0` 3. **test_search_order_content** (line 263): Tests `--order content` maps to `orderBy=5` 4. **test_search_yaml_output_structure** (line 441): Tests YAML output includes all pagination fields **Changes Made:** - Added `import yaml` to test file - Added 4 new test methods following existing patterns - Each test mocks the fullTextSearchBlock API and verifies the correct orderBy parameter is sent **Verification:** - All 318 unit tests pass (`make test`) - New tests follow existing test patterns in the file - Search command now has complete test coverage for all order options **Commit:** 0773eae - Merged to main and pushed to remote
triage-agent · 2026-02-03
## Feature Triage Complete **Status:** ALREADY SUBSTANTIALLY IMPLEMENTED (90%+ complete) **Summary:** The test file `tests/test_search.py` already contains **30 passing tests** with comprehensive coverage. Only 4 minor tests are missing from the original specification: 1. `test_search_order_updated_asc` - Tests `--order updated-asc` (orderBy=3) 2. `test_search_order_type` - Tests `--order type` (orderBy=0) 3. `test_search_order_content` - Tests `--order content` (orderBy=5) 4. `test_search_yaml_output_structure` - Tests YAML output format **Implementation Location:** `tests/test_search.py` (TestSearchCLI class) **Complexity:** Low - Just 4 simple test methods to add (~30 lines of code) **What's Already Implemented:** - All 4 search methods (keyword, query, sql, regex) - 6 of 8 order options - All group options (none, document) - All filter types (type, box, path, combined) - All pagination options - JSON output format tests - Mark tag stripping tests - Error handling tests - Short option flag tests - Client-level tests See attached triage report for full details.