PLOW-42 - trckr

← PLOW-42

feature

Created: 2025-12-21 • Updated: 2025-12-21

Relationships Loading...

## Summary

Add session-specific counters to track issues completed and failed during a single trckr-plow run.

## Implementation

Add to `WorkflowState` in `src/trckr_plow/state.py`:

```python
@dataclass
class SessionStats:
    issues_completed: int = 0
    issues_failed: int = 0

# Add to WorkflowState:
session: SessionStats = field(default_factory=SessionStats)

def increment_completed(self) -> None:
    self.session.issues_completed += 1
    self._notify_change()

def increment_failed(self) -> None:
    self.session.issues_failed += 1
    self._notify_change()
```

Update `workflow.py` to call these methods:
- `increment_completed()` when issue status becomes 'done'
- `increment_failed()` when issue is marked blocked or skipped due to error

## Files to Modify

- `src/trckr_plow/state.py` - Add SessionStats dataclass and methods
- `src/trckr_plow/workflow.py` - Call increment methods at appropriate points
- `tests/test_state.py` - Add unit tests for new counters

## Acceptance Criteria

- [ ] SessionStats dataclass exists with issues_completed and issues_failed
- [ ] increment_completed() and increment_failed() methods work
- [ ] Counters are incremented at correct points in workflow
- [ ] State serialization includes session stats
- [ ] Unit tests pass
- [ ] Pure Python implementation (no agents)

Pull Requests (comma-separated URLs)

Attachments

Comments (2)

agent · 2025-12-21

## QA Verification Complete ✅ **Status**: VERIFIED - All acceptance criteria met ### Test Results - **Total Tests**: 739 passed - **Linting**: All checks passed - **Coverage**: 99% on state.py ### Verification Summary ✅ SessionStats dataclass implemented correctly ✅ increment_completed() and increment_failed() methods work ✅ Counters incremented at correct workflow points ✅ State serialization includes session stats (full roundtrip) ✅ Comprehensive unit tests (8 new tests covering all functionality) ✅ Pure Python implementation (no agents) ✅ Session stats preserved across reset_for_new_issue() ### Code Quality - Clean, well-documented code - Proper separation of concerns - State change notifications work correctly - No linting errors **Full verification report**: /tmp/qa-PLOW-42.md Implementation is production-ready.

agent · 2025-12-21

## Implementation Complete ### Changes Made **src/trckr_plow/state.py**: - Added `SessionStats` dataclass with `issues_completed` and `issues_failed` counters (lines 107-117) - Added `session: SessionStats` field to `WorkflowState` dataclass (line 143) - Added `increment_completed()` method to increment issues_completed counter (lines 296-299) - Added `increment_failed()` method to increment issues_failed counter (lines 301-304) - Updated `_state_to_dict()` to include session stats in serialization (line 412) - Updated `_state_from_dict()` to parse session stats from dict (lines 476-480, 488) **src/trckr_plow/workflow.py**: - Call `increment_failed()` when marking issue as blocked due to non-recoverable error (line 1263) - Call `increment_completed()` when issue status is already 'done' after worker (line 1514) - Call `increment_completed()` when issue status is 'done' after QA (line 1577) **tests/test_state.py**: - Added `SessionStats` to imports - Added `TestSessionStats` test class with default values and with values tests - Updated `test_default_values` in TestWorkflowState to check session stats - Added `test_increment_completed`, `test_increment_failed`, and `test_session_stats_independent` tests - Added `test_reset_for_new_issue_preserves_session_stats` test - Updated serialization tests to verify session stats are included ### Verification - All 739 tests pass - Linting passes with no errors - Session stats are preserved across `reset_for_new_issue()` calls (session-level, not issue-level) - Serialization roundtrip works correctly with session stats