CLIAPI-41 - trckr

← CLIAPI-41

feature

Created: 2026-01-04 • Updated: 2026-01-06

Relationships Loading...

## Summary
Add router-level tests for multi-turn session endpoints. Service-layer tests exist but router tests are missing.

## Scope
Add to `tests/unit/test_sessions_router.py`:

### TestStreamSession class - GET /{session_id}/stream
- test_stream_session_success - Returns SSE stream
- test_stream_session_not_found - Session doesn't exist
- test_stream_session_already_completed - Session already done
- test_stream_session_cancelled - Session was cancelled

### TestSendMessage class - POST /{session_id}/messages
- test_send_message_success - Send message to running session
- test_send_message_not_found - Session doesn't exist
- test_send_message_not_running - Session not in running state
- test_send_message_validation - Invalid message format

### TestResumeSession class - POST /{session_id}/resume
- test_resume_session_success - Resume completed session
- test_resume_session_not_found - Session doesn't exist
- test_resume_session_already_running - Already running
- test_resume_session_with_prompt - Resume with new prompt

### TestContinueSession class - POST /{session_id}/continue
- test_continue_session_success - Continue after permission
- test_continue_session_not_found - Session doesn't exist
- test_continue_session_not_waiting - Not waiting for permission
- test_continue_session_with_input - Continue with input

## Technical Notes
- SSE streaming tests need to mock EventSourceResponse
- Use existing mock patterns from test_sessions_router.py
- Test session state transitions (running -> completed, etc.)

## Acceptance Criteria
- [ ] TestStreamSession class added with ~4 tests
- [ ] TestSendMessage class added with ~4 tests
- [ ] TestResumeSession class added with ~4 tests
- [ ] TestContinueSession class added with ~4 tests
- [ ] All tests pass (~16-20 new tests)
- [ ] No regressions

Pull Requests (comma-separated URLs)

Attachments

Comments (2)

QA Agent · 2026-01-06

Issue blockers resolved - all required methods now exist: - resume_session() implemented in CLIAPI-42 - continue_session() implemented in CLIAPI-43 - subscribe_to_session() already existed (renamed from subscribe()) Router tests for these endpoints were added in CLIAPI-48: - TestResumeSession (8 tests) - TestContinueSession (7 tests) - TestSendMessage (7 tests) - TestStreamSession tests exist in TestStreamSessionBasic and TestStreamSessionEventMapping All 22 tests for multi-turn endpoints pass. Marking as done.

triage-agent · 2026-01-04

## Feature Triage Complete **Status:** PARTIALLY BLOCKED **Summary:** This ticket requests router tests for 4 multi-turn endpoints. Investigation revealed: 1. **TestSendMessage** - CAN be implemented now (service method exists) 2. **TestStreamSession** - BLOCKED by bug (router calls `subscribe()` but method is `subscribe_to_session()`) 3. **TestResumeSession** - BLOCKED (service method `resume_session()` does not exist) 4. **TestContinueSession** - BLOCKED (service method `continue_session()` does not exist) **Implementation Location:** `tests/unit/test_sessions_router.py` (after line 1080) **Complexity:** Medium (once blockers resolved) **Recommendation:** - Create separate bug ticket for subscribe method name mismatch - Create feature tickets for missing service methods - Split this ticket or wait for dependencies See attached triage report (doc 724a98d2) for full details.