←
TRCKR-632
Created: 2025-12-26
•
Updated: 2025-12-27
Relationships
Loading...
Attachments
Loading...
Comments (3)
agent
·
2025-12-27
[QA] Verification Complete - PASSED
Testing: Live browser testing via chrome-devtools MCP
Results:
✅ Clear All button works correctly
✅ Dropdown Clear buttons still work
✅ No regressions detected
Full report: /tmp/qa-TRCKR-628.md
agent
·
2025-12-27
## Fix Applied
**Root Cause:** Function name collision in `server/templates/base.html`
Two functions were both named `clearAllFilters`:
1. Line 6353: No-args version that navigates to `/web/issues` (used by Clear All button in filter badges)
2. Line 6549: Two-args version `clearAllFilters(dropdownId, filterName)` for clearing individual dropdown filters
The second function was assigned to `window.clearAllFilters` at line 6584, overwriting the first. When the Clear All button called `clearAllFilters()` with no arguments, it invoked the two-args version which did nothing when called without arguments.
**Fix:**
- Renamed the two-args function from `clearAllFilters` to `clearDropdownFilter` (base.html:6549)
- Added `window.clearDropdownFilter = clearDropdownFilter` export (base.html:6585)
- Updated all 6 usages in `issues_table.html` to call `clearDropdownFilter` instead:
- Line 36: status dropdown
- Line 65: priority dropdown
- Line 86: agent_status dropdown
- Line 107: label dropdown
- Line 126: project dropdown
- Line 145: assignee dropdown
**Verification:**
- All 1400+ tests pass (2 pre-existing failures unrelated to this change)
- The no-args `clearAllFilters()` now correctly remains assigned to `window.clearAllFilters`
**QA Steps:**
1. Navigate to /web/issues
2. Apply multiple filters (e.g., 2 statuses and 1 priority)
3. Verify 'Clear All' button appears
4. Click 'Clear All' - should navigate to /web/issues and show unfiltered list
5. Also verify individual dropdown 'Clear' buttons still work
triage-agent
·
2025-12-26
## Bug Triage Complete
**Reproduction:** CONFIRMED
**Root Cause:** Function redefinition in `server/templates/base.html`
Two functions named `clearAllFilters` are defined:
1. Line 6353: No-args version that navigates to /web/issues (correct)
2. Line 6549: Two-args version for dropdown clearing (overwrites #1)
The second function overwrites the first via `window.clearAllFilters = clearAllFilters` at line 6584, causing the Clear All button to call a function that does nothing when invoked without arguments.
**TDD Approach:**
1. Rename the dropdown-specific function to `clearDropdownFilters(dropdownId, filterName)`
2. Update global assignment order so the correct `clearAllFilters()` is exposed
3. Update E2E test to actually click the button instead of using navigate workaround
**Complexity:** Low (simple rename refactor)
See triage report: /tmp/triage-TRCKR-628.md