?
SIYUAN-11
feature
Created: 2026-02-02 Updated: 2026-02-02
Relationships Loading...
Attachments
Loading...
Comments (3)
QA Agent · 2026-02-02
## QA Verification Complete - PASSED ✅ **QA Agent:** code-verification-qa **Status:** VERIFIED **Date:** 2026-02-02 ### Verification Summary All requirements for SIYUAN-11 have been successfully verified: **Code Implementation:** ✅ Client methods: export_resources(), push_msg(), push_err_msg() - all correct ✅ CLI commands: siyuan export resources, siyuan notify - all working ✅ Handlers: handle_export_resources(), handle_notify() - all correct **Test Coverage:** ✅ 260 unit tests passing (100% pass rate) ✅ 37 new tests added (15 export + 22 notify) ✅ 964 lines of test code ✅ Integration tests properly structured (23 tests) ✅ Coverage includes: happy paths, error cases, edge cases (unicode, multiline, empty, null) **Code Quality:** ✅ Follows project conventions ✅ Proper type hints and docstrings ✅ Comprehensive help text with examples ✅ No security issues ✅ No bugs found **Detailed QA Report:** /tmp/qa-SIYUAN-11.md **Recommendation:** Ready for production use.
agent · 2026-02-02
## Implementation Complete ### Changes Made **Client Methods (siyuan.py:661-704)** - `export_resources(paths, name)` - Export files/folders as a zip file via `/api/export/exportResources` - `push_msg(msg, timeout)` - Push notification message via `/api/notification/pushMsg` - `push_err_msg(msg, timeout)` - Push error notification via `/api/notification/pushErrMsg` **Handlers (siyuan.py:1241-1268)** - `handle_export_resources()` - Handler for export resources command - `handle_notify()` - Handler for notify command (handles both normal and error messages) **CLI Commands (siyuan.py:2099-2155)** - `siyuan export resources PATHS... [--name NAME]` - Export resources as zip - `siyuan notify MSG [--timeout MS] [--error]` - Push notification ### Tests Added - `tests/test_export.py` - 15 unit tests for export commands - `tests/test_notify.py` - 22 unit tests for notify commands - `tests/integration/test_export_live.py` - 6 integration tests - `tests/integration/test_notify_live.py` - 17 integration tests ### Verification - All 260 unit tests pass (`make test`) - Integration tests properly skip when SIYUAN_TOKEN not set - CLI commands verified working: `siyuan export --help`, `siyuan notify --help`
triage-agent · 2026-02-02
## Feature Triage Complete **Status:** PARTIALLY IMPLEMENTED **Summary:** - Markdown export already exists as `siyuan doc export` - Need to add `export resources` command (uses `/api/export/exportResources`) - Need to add `notify` command with `--error` flag (uses `/api/notification/pushMsg` and `pushErrMsg`) **Implementation Location:** - Client methods: `siyuan.py` lines 660+ (3 new methods) - Handlers: `siyuan.py` lines 1260+ (3-4 new handlers) - CLI commands: `siyuan.py` lines 2018+ (`export` and `notify` groups) - Tests: 4 new test files **Complexity:** Low-Medium **Key Findings:** - API endpoints documented in SiYuan GitHub - exportResources returns ZIP path in `temp/export/` directory - pushMsg/pushErrMsg return message ID for tracking - Default notification timeout is 7000ms See attached triage report for full implementation details.