?
FACE-14
feature
Created: 2025-12-25 Updated: 2025-12-27
Relationships Loading...
Attachments
Loading...
Comments (3)
agent · 2025-12-27
[QA] ✅ VERIFICATION PASSED Comprehensive QA testing completed on commit f5ce9982c. All acceptance criteria met: - ✅ --resolution 4k tests 4K videos - ✅ --resolution 8k tests 8K videos - ✅ Separate golden masters per resolution (golden-masters-4k, golden-masters-8k) - ✅ Default behavior unchanged (720p without flag) - ✅ Missing directories handled gracefully with warnings Testing performed: - Code review: All requirements implemented correctly - Functional testing: 720p, 4K, and 8K modes all work - Edge cases: Missing directories handled without crashes - Backward compatibility: Default 720p behavior unchanged Recommendation: Ready to merge to main. Full QA report: /tmp/qa-FACE-14.md
agent · 2025-12-27
## Implementation Complete ### Changes Made Updated evaluation/run_eval.py to support multi-resolution testing: 1. **Added --resolution flag** (line 430-432) - Choices: 720p, 4k, 8k (default: 720p) 2. **Added resolution configuration** (lines 54-79) - RESOLUTION_CONFIG dict maps resolution to (dataset_dir, source_face, golden_suffix) - get_resolution_paths() returns resolution-specific paths 3. **Updated get_video_ids()** (lines 82-119) - Now handles different directory structures: - 720p: nested 300vw/{id}/vid.avi - 4k/8k: flat 300vw-{res}/{id}.mp4 - Gracefully handles missing directories with a warning 4. **Updated run_face_swap()** (lines 142-167) - Added get_video_path() helper for resolution-aware input paths - Now accepts dataset_dir, source_face, and resolution parameters 5. **Updated golden master functions** (lines 214, 264) - compare_with_golden() and save_as_golden() now use passed golden_dir 6. **Updated run_evaluation()** (lines 283-425) - Added resolution parameter - Resolution-specific temp output directories - Resolution included in results and per-video metrics ### Testing Verified with --help and dry runs for all resolutions: - 720p: Uses 300vw/, face-cage.jpg, golden-masters/ - 4k: Uses 300vw-4k/, face-cage-4k.jpg, golden-masters-4k/ - 8k: Uses 300vw-8k/, face-cage-8k.jpg, golden-masters-8k/ Default behavior (no --resolution flag) unchanged - works exactly as before with 720p.
triage-agent · 2025-12-27
## Feature Triage Complete **Status:** NOT IMPLEMENTED - Ready for implementation **Summary:** This feature extends run_eval.py to support testing at multiple resolutions (720p, 4k, 8k). All dependencies are satisfied: - FACE-12 (4K videos) Done - FACE-13 (8K videos) Done - Source face images at all resolutions already exist **Key Changes Required:** 1. Add `--resolution` flag (choices: 720p, 4k, 8k) 2. Update `get_video_ids()` to handle different directory structures: - 720p: `300vw/{id}/vid.avi` (nested) - 4k/8k: `300vw-{res}/{id}.mp4` (flat) 3. Add resolution-aware path helpers 4. Update golden master paths per resolution 5. Add resolution to metrics output 6. Handle missing directories gracefully (warning, not crash) **Data Available:** | Resolution | Videos | Format | Source Face | |------------|--------|--------|-------------| | 720p | 114 | AVI | face-cage.jpg | | 4K | 10 | MP4 | face-cage-4k.jpg | | 8K | 10 | MP4 | face-cage-8k.jpg | **Complexity:** Low (~50-80 lines changed) **Default Behavior:** Unchanged - without `--resolution` flag, works exactly as before. See full triage report at `/tmp/triage-FACE-14.md`