?
PLOW-7
config,refactoring
Created: 2025-12-21 Updated: 2025-12-21
Relationships Loading...
Attachments
Loading...
Comments (2)
code-verification-qa · 2025-12-21
## QA Verification: PASSED ✅ **Verified by:** code-verification-qa agent **Date:** 2025-12-21 **Commit:** d65a2ee ### Test Results - ✅ All 406 tests passing (100% pass rate) - ✅ Linting clean (ruff) - ✅ 99% coverage on loader.py ### Functionality Verified - ✅ Dynamic agent/template selection working - ✅ Bug classification → trckr-triage-bug + triage-bug.j2 - ✅ Feature classification → trckr-triage-feature + triage-feature.j2 - ✅ Fallback behavior on unknown/missing context - ✅ Both triage paths tested and working ### Code Quality - ✅ Well-documented with clear docstrings - ✅ Type-safe with proper hints - ✅ Comprehensive test coverage (5 new unit tests) - ✅ Backward compatible (legacy steps deprecated) ### Implementation Details 1. Added agent_selector/template_selector fields to StepConfig 2. Added resolve_agent_and_template(context) method 3. Created unified 'triage' step in agents.yml 4. Updated _resolve_selector() to use dynamic resolution 5. Refactored run_triage_agent() to use unified step **Full report:** /tmp/qa-PLOW-7.md **Recommendation:** Ready for production. Implementation complete and verified.
agent · 2025-12-21
## Implementation Complete Refactored run_triage_agent() to use dynamic agent/template selection based on classification. ### Changes Made 1. **StepConfig** (loader.py): - Added agent_selector, template_selector, selector_key fields - Added resolve_agent_and_template(context) method for dynamic resolution 2. **agents.yml**: - Added unified triage step with agent_selector and template_selector - Maps bug -> trckr-triage-bug + triage-bug.j2 - Maps feature -> trckr-triage-feature + triage-feature.j2 3. **workflow_v2.py**: - _resolve_selector() now uses resolve_agent_and_template(context) - _execute_configured_step() passes extra_vars as context - run_triage_agent() uses unified triage step with classification in extra_vars 4. **Tests**: - Added 5 tests for resolve_agent_and_template() - Updated mock config with unified triage step ### Verification - All 406 tests pass - Linting clean - Both bug and feature triage paths work correctly