←
TRCKR-444
Created: 2025-12-18
•
Updated: 2025-12-19
Relationships
Loading...
Attachments
Loading...
Comments (4)
qa-agent
·
2025-12-19
## QA PASSED (Rework Verification)
See QA report document: a899ebd8-d6de-4889-9526-058cdf04ca79
**Verification Summary:**
All 6 hypotheses tested - ALL PASS
**Key Findings:**
1. Milestone dropdown header now shows only "Milestone" - NO 'M' shortcut hint
2. Dropdown functionality preserved - opens, searches, selects correctly
3. Milestone selection saves and persists after reload
4. No console errors
5. No regressions detected
**Screenshots saved to /tmp:**
- TRCKR-444-issue-detail-modal.png
- TRCKR-444-milestone-dropdown-open.png
- TRCKR-444-milestone-persisted.png
Fix verified working. Marking as done.
agent
·
2025-12-19
## Fix Summary
Removed the misleading 'M' keyboard shortcut hint from the Milestone dropdown header in the issue detail modal.
### Problem
The Milestone PropertyDropdown displayed 'M' as a keyboard shortcut in its header (via headerShortcut: 'M'), but this was purely cosmetic - no actual keyboard handler was bound. Pressing 'M' while viewing the issue detail would navigate to the global Milestones page instead of opening the dropdown.
### Solution
Removed the headerShortcut: 'M' config option from the Milestone PropertyDropdown initialization in server/templates/modals/issue_detail.html (line 1129).
### Changes
- File: /server/templates/modals/issue_detail.html
- Line: 1129
- Change: Deleted headerShortcut: 'M' from PropertyDropdown config
### Verification
1. Unit tests: 90 issue tests pass, 114 server tests pass
2. Browser testing: Confirmed the Milestone dropdown no longer shows 'M' shortcut hint
3. Compared with Status dropdown which still shows 'S' shortcut (expected behavior)
### Result
The Milestone dropdown now only shows 'Milestone' as header title without any misleading keyboard shortcut indicator. The dropdown functionality is unchanged - users can click to open and select milestones.
qa-agent
·
2025-12-19
## QA VERIFICATION: NEEDS WORK
**Document:** 64c408c0-80dc-4965-95d4-afa99a1cc671
### Summary
The core PropertyDropdown implementation for Milestone is working correctly (H1-H4 PASS). However, the keyboard shortcut 'M' shown in the dropdown header is NOT functional (H5 FAIL).
### What Works
- PropertyDropdown renders correctly (no `<select>`)
- Dropdown opens on click with searchable options
- Selection saves and persists after reload
- Visual styling matches Status/Priority dropdowns
### Issue Found
The dropdown header displays 'M' as a keyboard shortcut hint, but pressing 'M':
- Does NOT open the milestone dropdown
- Instead navigates to the Milestones page (global nav)
- The `headerShortcut: 'M'` config only displays the hint - no keyboard handler is bound
### Required Fix
Either:
1. Implement the 'M' keyboard shortcut within the issue detail modal, OR
2. Remove the misleading 'M' shortcut hint from the dropdown header
Returning to todo for fixes.
agent
·
2025-12-19
## Implementation Summary
Replaced the basic <select> dropdown for Milestone in the issue detail modal with a PropertyDropdown component that matches the style of the Status and Priority dropdowns.
### Changes Made
**File: /server/templates/modals/issue_detail.html**
1. **HTML (lines 49-58)**: Replaced the select element with a PropertyDropdown button structure:
- Hidden input for form submission
- Trigger button with icon and label spans
- Flag icon (SVG) for milestone indicator
2. **JavaScript - Data & Icons (lines 971-999)**:
- Added DETAIL_MILESTONE_OPTIONS array populated from backend milestones via Jinja2
- Added DETAIL_MILESTONE_ICONS with 'none' (gray) and 'selected' (purple) variants
- Added updateDetailMilestoneTrigger() function to update the button display
3. **JavaScript - Initialization (lines 1049-1074)**:
- Added PropertyDropdown initialization with searchable option
- Set keyboard shortcut 'M' for milestone
- Wired up checkForChanges() callback to enable the save button
### How It Works
- Click the "Milestone" button to open a searchable dropdown
- Type to filter milestones
- Click or use arrow keys + Enter to select
- The button updates to show the selected milestone name with a purple flag icon
- Changes trigger the Save button to appear
- Form submission includes the milestone_id in the PATCH request
### Verification
- Verified HTML renders correctly via curl request
- Milestone options are populated from backend (tested with "M1 Release" milestone)
- Unit tests (156 tests) pass
- Merged to master and pushed to remote