?
DOCMOST-4
feature
Created: 2026-01-18 Updated: 2026-01-18
Relationships Loading...
Attachments
Loading...
Comments (3)
QA-Agent · 2026-01-18
## QA PASSED ✅ **Verification Date:** 2026-01-18 **Commit Verified:** 4143b02 **Test Results:** - ✅ All 232 tests pass (including 5 new tests for members-change-role) - ✅ CLI help shows members-change-role command - ✅ Command options verified (SPACE_ID, --user-id/-u, --group-id/-g, --role/-r) - ✅ Code follows project patterns and standards - ✅ Input validation works correctly - ✅ Error handling is proper - ✅ No security issues found **Implementation Quality:** Excellent - follows existing patterns, comprehensive test coverage, clear error messages, proper validation. **Detailed QA report:** /tmp/qa-DOCMOST-4.md Ready for production.
agent · 2026-01-18
## Implementation Complete Added `spaces members-change-role` command to `src/docmost/commands/spaces.py:175-202`. **Changes:** - New command accepts SPACE_ID argument and --user-id/-u, --group-id/-g, --role/-r options - Validates that either user-id or group-id is provided - Calls POST /spaces/members/change-role endpoint with spaceId, role, and userId/groupId **Tests added** to `tests/test_commands_spaces.py:306-366`: - test_change_role_for_user - changes role via --user-id - test_change_role_for_group - changes role via --group-id - test_change_role_requires_user_or_group - validates input - test_change_role_requires_role - validates required option - test_change_role_error - handles API errors **Verification:** - All 232 tests pass - CLI help shows command with correct options - QA instructions verified manually
triage-agent · 2026-01-18
## Feature Triage Complete **Status:** NOT IMPLEMENTED **Summary:** The `spaces members-change-role` command does not exist in the CLI. The API endpoint `/spaces/members/change-role` is confirmed to exist in the Postman collection. This is a straightforward addition following the existing pattern of `members-add` and `members-remove` commands. **Implementation Location:** - `src/docmost/commands/spaces.py` - Add new command (~30 lines) - `tests/test_commands_spaces.py` - Add tests (~60 lines) - `README.md` - Update documentation (~5 lines) **Complexity:** Low - follows established patterns exactly See attached triage report at `/tmp/triage-DOCMOST-4.md` for full details.