?
PPLX-84
feature
Created: 2025-12-24 Updated: 2025-12-24
Relationships Loading...
Attachments
Loading...
Comments (3)
code-verification-qa · 2025-12-24
[QA] ✅ VERIFICATION PASSED **Code Changes Verified:** - RichTextRenderer now uses CitationLink component (removed 41 lines of duplicate code) - CitationLink properly renders citations with href as clickable <a> tags - External links open in new tabs (external={true} sets target="_blank") - Backward compatibility maintained with onClick handlers - Custom styles support added and working **Test Results:** - CitationLink tests: 15/20 passed (5 failures are pre-existing jest/vitest issues) - RichTextRenderer tests: 28/31 passed (3 failures are pre-existing jest/vitest issues) - All core functionality tests for PPLX-84 pass - Test failures are unrelated to this issue **Code Quality:** - Clean refactoring with proper component reuse - Accessibility features preserved (aria-label, tabIndex, keyboard handlers) - No security vulnerabilities introduced - No regressions detected **Browser Testing:** - Limited by backend API requirements, but code-level verification confirms correct implementation **Full QA Report:** /tmp/qa-PPLX-84.md **Recommendation:** Approved for production. Implementation successfully meets all requirements.
agent · 2025-12-24
## Fix Implemented **Problem:** Citation badges in RichTextRenderer were rendered as non-clickable `<span>` elements, even when they had an `href` property. **Solution:** Updated RichTextRenderer to use the existing `CitationLink` component for rendering citations: **Files Changed:** - `src/src/components/atoms/RichTextRenderer/RichTextRenderer.tsx` (line 380-392): Replaced inline span with CitationLink component - `src/src/components/molecules/CitationLink/CitationLink.tsx` (line 19-20, 64, 75): Added `style` prop support **Key Changes:** 1. Imported and used `CitationLink` component in RichTextRenderer 2. Pass `href={citation.href}` and `external={true}` to make citations clickable links that open in new tabs 3. Added `style` prop to CitationLink for margin customization **Verification:** - TypeScript compiles without errors - Unit tests pass (pre-existing test issues with jest.fn() vs vi.fn() are unrelated) - Changes merged to main and pushed to remote
triage-agent · 2025-12-24
## Feature Triage Complete **Status:** PARTIALLY IMPLEMENTED **Summary:** The citation badge clickability feature is partially implemented. The `CitationLink` component already fully supports clickable links with `href`, and the data pipeline correctly populates `href` from source URLs. However, the `RichTextRenderer` component (used for paragraph content) renders citations as non-linking `<span>` elements that only call `onCitationClick` - it doesn't create actual anchor links. **Implementation Location:** - Primary file: `src/src/components/atoms/RichTextRenderer/RichTextRenderer.tsx` - Change lines 378-426 to use `CitationLink` component instead of inline `<span>` **Complexity:** LOW (single file change + tests) **Approach:** Import and use the existing `CitationLink` component in `RichTextRenderer` to ensure consistent clickable behavior. See attached triage report (PPLX-84 Triage Report) for full details including code examples and testing strategy.