TRCKR-172 - trckr

← TRCKR-172

sync refactoring

Created: 2025-12-09 • Updated: 2025-12-16

Relationships Loading...

The `sync_on_change` setting in `sync_state` is unnecessary complexity. If a sync server is configured, we should always sync immediately after local changes. There's no valid use case for having a server configured but NOT wanting immediate sync.

## Current State

The `sync_state` table has:
- `sync_on_change` (INTEGER, default 1) - Whether to sync after each change
- `auto_sync` (INTEGER, default 1) - Whether to run periodic background sync

The `SyncEngine` checks `should_sync_on_change()` before triggering sync after operations.

## Proposed Change

1. Remove `sync_on_change` column from `sync_state` table
2. Simplify logic: if `server_url` is configured → always sync on change
3. Keep `auto_sync` for periodic background sync (still useful for catching missed syncs)

## Files to Modify

- `client/store.py` - Remove sync_on_change from schema and sync_state operations
- `client/sync.py` - Simplify `should_sync_on_change()` to just check if server is configured
- `client/schema.py` - Update schema if sync_state table definition is there
- `tests/` - Update any tests that reference sync_on_change

## Acceptance Criteria

- `sync_on_change` setting no longer exists
- Sync happens automatically after every change when server_url is set
- All tests pass
- Migration handles existing databases (drop column or ignore)

Pull Requests (comma-separated URLs)

Attachments

Comments (1)

agent · 2025-12-09

Completed removal of sync_on_change setting. ## Changes Made ### Core Files - **client/schema.py:410** - Removed sync_on_change column from SYNC_STATE_TABLE definition - **client/sync.py:137-171** - Removed sync_on_change parameter from configure() method - **client/sync.py:173-176** - Simplified should_sync_on_change() to just check if server_url is configured (returns status.is_configured) - **trckr.py:686-691** - Removed sync_on_change parameter from engine.configure() call in sync setup command ### Test Files - **tests/test_live_server.py:113-117** - Removed sync_on_change parameter from fixture - **tests/integration/conftest.py:90-95, 104-109, 239-243** - Removed sync_on_change from all SyncEngine.configure() calls - **tests/integration/test_sync_race_conditions.py:35** - Updated docstring to reflect new behavior - **tests/integration/test_sync_race_conditions.py:346-350** - Removed sync_on_change parameter ## Behavior Changes - **Before**: Users could configure a sync server but disable sync-on-change, requiring manual sync - **After**: If a sync server is configured, changes are always synced immediately after local operations ## Migration Compatibility - Existing databases with sync_on_change column will continue to work - SQLite allows reading rows with extra columns that aren't referenced in queries - The column can remain in existing databases without causing issues ## Verification - Tested that should_sync_on_change() returns False when no server configured - Tested that should_sync_on_change() returns True when server is configured - All changes committed and pushed to TRCKR-172 branch - Branch merged to master and pushed to remote