PLOW-43 - trckr

← PLOW-43

feature

Created: 2025-12-21 • Updated: 2025-12-21

Relationships Loading...

## Summary

Create a new module to send exit notifications via the ntfy CLI.

## Implementation

Create `src/trckr_plow/notify.py`:

```python
import logging
import shutil
import socket
import subprocess
from dataclasses import dataclass

logger = logging.getLogger(__name__)

@dataclass
class NotifyConfig:
    enabled: bool = False
    server: str = "https://ntfy.roboalch.com"
    topic: str = "all"

@dataclass 
class QueueStatus:
    triage: int = 0
    todo: int = 0
    in_progress: int = 0
    in_review: int = 0
    done: int = 0
    blocked: int = 0

@dataclass
class SessionStats:
    completed: int = 0
    failed: int = 0

def send_exit_notification(
    project: str,
    reason: str,
    session: SessionStats,
    queue: QueueStatus,
    config: NotifyConfig,
) -> bool:
    """Send exit notification via ntfy CLI.
    
    Returns True if notification sent, False otherwise.
    Fails silently if ntfy not installed.
    """
    if not config.enabled:
        return False
        
    if not shutil.which("ntfy"):
        logger.warning("ntfy CLI not found - skipping notification")
        return False
    
    hostname = socket.gethostname()
    
    message = f"""Project: {project}
Host: {hostname}
Reason: {reason}
Session: {session.completed} completed, {session.failed} failed

Queue:
  Triage: {queue.triage} | Todo: {queue.todo} | In Progress: {queue.in_progress}
  In Review: {queue.in_review} | Done: {queue.done} | Blocked: {queue.blocked}"""
    
    url = f"{config.server}/{config.topic}"
    
    try:
        subprocess.run(
            ["ntfy", "pub", "-t", "trckr-plow exited", "-T", "robot", url, message],
            capture_output=True,
            timeout=10,
        )
        return True
    except Exception as e:
        logger.warning(f"Failed to send notification: {e}")
        return False
```

## Files to Create

- `src/trckr_plow/notify.py` - Notification module

## Files to Modify

- `tests/test_notify.py` - Unit tests with mocked subprocess

## Acceptance Criteria

- [ ] send_exit_notification() function works with all parameters
- [ ] Returns False and logs warning if ntfy not installed
- [ ] Returns False if config.enabled is False
- [ ] Includes project, hostname, reason, session stats, queue status
- [ ] Uses subprocess.run() with timeout
- [ ] Unit tests pass with mocked subprocess
- [ ] Pure Python implementation (no agents)

Pull Requests (comma-separated URLs)

Attachments

Comments (2)

agent · 2025-12-21

[QA VERIFICATION] ✅ VERIFIED - All acceptance criteria met. All 788 tests pass (including 15 new notify tests). Code quality checks pass. No regressions. Implementation correctly uses ntfy CLI with subprocess.run(), handles missing ntfy gracefully, and includes all required fields in notifications. See /tmp/qa-PLOW-43.md for full verification report.

agent · 2025-12-21

Implemented ntfy notification module as specified: **Changes Made:** - Updated src/trckr_plow/notify.py to use ntfy pub CLI instead of curl - Added shutil.which('ntfy') check that returns False and logs warning if ntfy not installed - Set default server to https://ntfy.roboalch.com and topic to all per spec - Simplified NotifyConfig (removed priority/tags fields not in spec) - Updated src/trckr_plow/settings.py to match simplified config - Updated tests/test_notify.py with 15 tests covering all acceptance criteria - Updated tests/test_settings.py for new defaults **Verification:** - All 788 tests pass - Linting passes (ruff check) **Key implementation details:** - send_exit_notification() uses ntfy pub -t 'trckr-plow exited' -T robot <url> <message> - Returns False if config.enabled is False (no CLI check needed) - Returns False and logs warning if ntfy CLI not found in PATH - Uses subprocess.run() with 10 second timeout - Message includes project, hostname, reason, session stats, and queue status