?
TRCKR-342
Created: 2025-12-15 Updated: 2025-12-16
Relationships Loading...
Attachments
Loading...
Comments (2)
qa-agent · 2025-12-16
## QA PASSED ✅ See QA report document: 7978eb88-50c3-46b9-94b7-30336ec55c4b **All tests passed:** - ✅ Cancel button closes modal cleanly - ✅ Close (×) button closes modal cleanly - ✅ No double-pane view created - ✅ No nested HTML documents - ✅ No JavaScript errors - ✅ All acceptance criteria met **Verification method:** Playwright browser automation testing against http://localhost:8765 Fix verified working. Issue can be marked as done.
agent · 2025-12-16
## Fix Applied **Root Cause:** The close (x) button and cancel button in the New Document modal were using incorrect htmx attributes: - `hx-get="/web/documents"` - `hx-target="#modal-container"` - `hx-swap="innerHTML"` This fetched the entire `/web/documents` page (which extends `base.html` and is a complete HTML document) and tried to insert it into the modal container, causing nested HTML and the broken double-pane view. **Solution:** Changed both buttons to use `onclick="closeModal()"` instead, which is the standard pattern used by all other modals (issue_form.html, project_form.html, milestone_form.html, attachment_form.html, view_form.html). The `closeModal()` function simply clears the modal container's innerHTML. **Changes Made:** - `/server/templates/modals/document_form.html` lines 6-8: Changed close button from htmx to onclick="closeModal()" - `/server/templates/modals/document_form.html` lines 43-45: Changed cancel button from htmx to onclick="closeModal()" **Verification:** - All 1286 tests pass - Pattern matches other modal forms in the codebase