CLIAPI-42 - trckr

← CLIAPI-42

feature

Created: 2026-01-04 • Updated: 2026-01-05

Relationships Loading...

## Summary
Implement the missing `resume_session()` method in SessionManager that enables resuming completed sessions with a new prompt.

## Background
The router endpoint `POST /v1/sessions/{id}/resume` exists (lines 477-533 in sessions.py) but calls `session_manager.resume_session()` which does not exist. This causes an AttributeError at runtime.

## Implementation

Add to `src/cli_agent_api/services/session_manager.py`:

```python
async def resume_session(
    self,
    session_id: str,
    prompt: str,
    fork: bool = False,
) -> SessionActionResponse:
    """Resume a completed session with a new prompt.
    
    Args:
        session_id: The completed session to resume.
        prompt: New prompt to continue with.
        fork: If True, create new session ID instead of reusing original.
        
    Returns:
        SessionActionResponse with status and optional forked_session_id.
        
    Raises:
        SessionNotFoundError: If session doesn't exist.
        SessionNotCompletedError: If session is not in completed/failed/cancelled state.
    """
```

The method should:
1. Get the original session and validate it's completed/failed/cancelled
2. Create a new SessionConfig copying relevant fields (working_dir, model, etc.)
3. Add `--resume <session_id>` to the config (may need to extend SessionConfig)
4. If fork=True, add `--fork-session` flag
5. Start new Claude process via `create_session()`
6. Return SessionActionResponse

## Files to Modify
- `src/cli_agent_api/services/session_manager.py` - Add method (~60 lines)
- `src/cli_agent_api/models/session.py` - May need to add resume_session_id field to SessionConfig
- `tests/unit/test_session_manager.py` - Add tests (~50 lines)

## Acceptance Criteria
- [ ] `resume_session()` method exists in SessionManager
- [ ] Calling `POST /v1/sessions/{id}/resume` no longer crashes with AttributeError
- [ ] Method validates session is completed before resuming
- [ ] Method supports fork_session parameter
- [ ] 5+ unit tests added covering: success, not-found, not-completed, fork behavior

## QA Instructions
1. Run `pytest tests/unit/test_session_manager.py -v -k resume` - all tests pass
2. Start server, create a session, let it complete, then call resume endpoint
3. Verify no AttributeError occurs
4. Check that resumed session starts running

Pull Requests (comma-separated URLs)

Attachments

Comments (2)

agent · 2026-01-05

## Implementation Complete ### What was done: 1. **Added resume fields to SessionConfig** (`src/cli_agent_api/models/session.py:142-147`) - `resume_session_id: str | None` - For `--resume` flag - `fork_session: bool` - For `--fork-session` flag 2. **Updated ClaudeWrapper.build_command()** (`src/cli_agent_api/services/claude.py:297-302`) - Adds `--resume <session_id>` when resume_session_id is set - Adds `--fork-session` when fork_session is True 3. **Implemented resume_session() method** (`src/cli_agent_api/services/session_manager.py:502-591`) - Validates session exists and is completed/failed/cancelled - Copies all relevant config fields from original session - Sets resume_session_id and fork_session on new config - Creates new session via create_session() - Returns SessionActionResponse with forked_session_id when fork=True ### Tests added: - test_resume_session_not_found - test_resume_session_not_completed - test_resume_completed_session - test_resume_session_with_fork - test_resume_failed_session - test_resume_cancelled_session - test_resume_copies_config_fields - test_build_command_with_resume - test_build_command_with_fork_session - test_build_command_fork_without_resume All 809 unit tests pass. Commit: c9e7340

triage-agent · 2026-01-05

## Feature Triage Complete **Status:** NOT IMPLEMENTED **Summary:** The `resume_session()` method is missing from SessionManager. The router endpoint `POST /v1/sessions/{id}/resume` exists and performs session validation, but calls a non-existent method causing an AttributeError at runtime. **Implementation Location:** - `SessionManager.resume_session()` - Add new method (~60 lines) - `SessionConfig` - Add `resume_session_id` and `fork_session` fields - `ClaudeWrapper.build_command()` - Add `--resume` and `--fork-session` flag handling **Complexity:** MEDIUM - Changes across 4 files following existing patterns **Key Findings:** - Router validation already complete (checks session exists, is completed) - Mock CLI already supports `--resume` and `--fork-session` flags - `SessionActionResponse` already has `forked_session_id` field - Similar patterns exist in `create_session()` and `cancel_session()` See attached triage report (doc c845afe2-a765-41bf-821d-6b64a4a48d93) for full details.