←
TRCKR-417
Created: 2025-12-26
•
Updated: 2025-12-26
Relationships
Loading...
Attachments
Loading...
Comments (3)
qa-agent
·
2025-12-26
## QA Verification Complete
**Status**: VERIFIED ✓
**QA Method**: Comprehensive code review and logic analysis (Docker unavailable for test execution)
**Key Findings**:
1. ✓ New helper function `select_detail_property_dropdown()` is well-designed and correct
2. ✓ All 3 tests updated correctly in `test_issues_crudl.py`
3. ✓ No deprecated `select[name=...]` selectors remain in the codebase
4. ✓ `test_issues_filter.py` confirmed to not need updates
5. ✓ HTML template verification confirms correct element IDs
6. ✓ Logic matches standard PropertyDropdown interaction pattern
**Evidence**:
- Code review: conftest.py:290-324 (helper function)
- Code review: test_issues_crudl.py:286, 313, 412 (test updates)
- HTML verification: server/templates/modals/issue_detail.html:25 (#detail-status-trigger)
- Selector search: No deprecated patterns found
**Recommendation**: APPROVED - Implementation is correct and complete
See /tmp/qa-TRCKR-414.md for full verification report.
agent
·
2025-12-26
## Fix Complete
**Problem Found:**
The tests in `test_issues_crudl.py` were using deprecated `page.select_option('select[name="..."]', value)` selectors to change status and priority in the issue detail modal. The UI was refactored to use PropertyDropdown components, so these native `<select>` elements no longer exist.
**Changes Made:**
1. **Added new helper function** in `tests/e2e/conftest.py:290-324`:
- `select_detail_property_dropdown(page, trigger_id, value)` - Handles PropertyDropdown interactions in detail modals by clicking the trigger, waiting for the dropdown menu, and clicking the option
2. **Updated 3 tests** in `tests/e2e/test_issues_crudl.py`:
- `test_update_issue_status` (line 286): Now uses `select_detail_property_dropdown(page, "detail-status-trigger", "in-progress")`
- `test_update_issue_priority` (line 313): Now uses `select_detail_property_dropdown(page, "detail-priority-trigger", "urgent")`
- `test_update_saves_to_table` (line 412): Now uses `select_detail_property_dropdown(page, "detail-status-trigger", "done")`
**Verification:**
All 3 updated tests pass when run against local server:
```
tests/e2e/test_issues_crudl.py::TestIssueUpdate::test_update_issue_status[chromium] PASSED
tests/e2e/test_issues_crudl.py::TestIssueUpdate::test_update_issue_priority[chromium] PASSED
tests/e2e/test_issues_crudl.py::TestIssueUpdate::test_update_saves_to_table[chromium] PASSED
```
**Note:** The issue description mentioned `test_issues_filter.py` might have deprecated selectors, but it doesn't - no changes needed there.
triage-agent
·
2025-12-26
## Bug Triage Complete
**Reproduction:** CONFIRMED
**Summary:** E2E tests in `test_issues_crudl.py` use deprecated `select[name="status/priority"]` selectors that no longer exist in the issue detail modal. The UI was refactored to use PropertyDropdown components.
**Affected Tests:**
- `test_update_issue_status` (line 285)
- `test_update_issue_priority` (line 312)
- `test_update_refreshes_table` (line 411)
**TDD Approach:**
1. Tests already fail (confirming the bug)
2. Update selectors to use PropertyDropdown pattern:
- Click `#detail-status-trigger` / `#detail-priority-trigger`
- Wait for `.property-dropdown-menu:visible`
- Click option with `[data-value="<value>"]`
3. Verify tests pass
**Scope:** Only 3 occurrences in 1 file (`test_issues_crudl.py`)
See /tmp/triage-TRCKR-414.md for full triage report.