?
CLIAPI-26
feature
Created: 2026-01-03 Updated: 2026-01-04
Relationships Loading...
Attachments
Loading...
Comments (2)
agent · 2026-01-04
## Implementation Complete ### Changes Made - Added 9 new permission rules CRUD endpoints to `src/cli_agent_api/routers/config.py`: - GET /v1/config/permission-rules/{source} - list all rules from a source - GET /v1/config/permission-rules/{source}/{rule_type} - get rules by type (allow/deny/ask) - POST /v1/config/permission-rules/add - add a permission rule - DELETE /v1/config/permission-rules/remove - remove a permission rule - DELETE /v1/config/permission-rules/clear - clear rules (all or by type) - POST /v1/config/permission-rules/move - move rule between types - PUT /v1/config/permission-rules/additional-directories - set directories - POST /v1/config/permission-rules/additional-directories/add - add directory - DELETE /v1/config/permission-rules/additional-directories/remove - remove directory ### Files Modified - `src/cli_agent_api/routers/config.py:28-32` - Added PermissionRulesManager import - `src/cli_agent_api/routers/config.py:72-87` - Added _get_permission_rules_manager helper - `src/cli_agent_api/routers/config.py:577-986` - Added all permission rules endpoints ### New Test File - `tests/unit/test_config_router_permission_rules.py` - 21 tests covering all endpoints ### Verification - All 21 new tests pass - All 159 config-related tests pass (config, config_reader, hook_manager, permission_rules_manager) - Merged to main (CLIAPI-1) and pushed to remote ### QA Criteria Status - [x] Can list, add, delete hooks via API (already implemented in CLIAPI-24) - [x] Can list, add, delete permission rules via API (newly implemented) - [x] Changes persist after server restart (uses PermissionRulesManager which writes to settings.json) - [x] Returns proper error for invalid configurations (400 status with detail message)
triage-agent · 2026-01-04
## Feature Triage Complete **Status:** PARTIALLY IMPLEMENTED ### Summary - **Hooks endpoints:** FULLY IMPLEMENTED - All CRUD operations already exist - **Permission rules endpoints:** PARTIAL - Only GET exists, need POST/DELETE operations ### What Exists - GET /v1/config/hooks (and variants) - complete CRUD for hooks - GET /v1/config/permissions - returns merged permissions ### What's Missing - POST /v1/config/permission-rules/add - DELETE /v1/config/permission-rules/remove - DELETE /v1/config/permission-rules/clear - GET /v1/config/permission-rules/{source} ### Implementation Notes - PermissionRulesManager service (CLIAPI-25) is fully implemented - Just need to add API endpoints following hooks pattern - Complexity: LOW (straightforward pattern match) See /tmp/triage-CLIAPI-26.md for full details.