TRCKR-837 - trckr

← TRCKR-837

bug sync server

Created: 2026-01-08 • Updated: 2026-01-08

Relationships Loading...

## Problem

When documents are synced from client to server, only the metadata (title, slug, path, tags, entity_type, entity_id) is transferred. The actual **document body content** (stored in markdown files at `documents/*.md`) is NOT synced.

## Evidence

- Document `c5f465a4-1037-4b07-9948-123509a12f62` (APLANE-21 QA Report) has 3990 bytes of body content locally
- Same document on server shows empty `initialContent` (length 0)
- The `path` field points to a file that doesn't exist on the server

## Root Cause

In `server/routes/sync.py`, the `_apply_create` function for documents (lines 912-934) only syncs metadata fields, not body content:

```python
result = store.create_document(
    title=data.get("title", "Untitled"),
    slug=data.get("slug", ""),
    path=data.get("path", ""),
    entity_type=data.get("entity_type"),
    entity_id=data.get("entity_id"),
    tags=data.get("tags", []),
    id=change.entity_id,
)
# No body is written to file!
```

Compare to REST API create (`server/routes/documents.py` lines 100-104) which does write body:
```python
body_content = document.body or ""
doc_path = store.base_dir / created["path"]
doc_path.parent.mkdir(parents=True, exist_ok=True)
doc_path.write_text(body_content)
```

## Impact

- **All documents synced from CLI have empty bodies on server**
- Document detail pages show empty content
- E2E tests pass because they create documents via API (which works)

## Solution

1. **Client side**: Include `body` field in SyncChange data for documents
2. **Server side**: Write body to file in `_apply_create` for documents
3. **Update side**: Also handle body in `_apply_update` for documents

## Affected Code

- `server/routes/sync.py`: `_apply_create` and `_apply_update` for documents
- `cli/sync.py` (or wherever client builds sync changes): Include body in document sync data

## Acceptance Criteria

- [ ] Document body content is included in sync changes from client
- [ ] Server writes body to file when creating/updating documents via sync
- [ ] Documents created locally appear with correct body on server
- [ ] E2E test verifies synced documents have correct body content

Pull Requests (comma-separated URLs)

Attachments

Comments (2)

qa-agent · 2026-01-08

## QA PASSED See QA report document: fe3998be-2272-46c9-a9e9-b8044e980810 **Summary:** - Fix verified working after reinstalling trckr CLI with `make install` - Documents created and synced now include body content on server - Web UI displays document body in Milkdown editor correctly **Root cause of initial test failure:** The system-wide trckr CLI was installed from an older version that didn't include the fix. After `make install`, the fix worked correctly. **Screenshots:** - /tmp/TRCKR-837-document-body-synced.png (body synced correctly) - /tmp/TRCKR-837-document-body-empty-before-fix.png (empty body before fix) All hypotheses tested. Fix verified working.

agent · 2026-01-08

## Fix Summary Fixed the document body sync issue where document body content was not being transferred from client to server during sync operations. ### Root Cause Two issues were identified: 1. **Client side** (client/store.py:349-388): The _log_sync_change method was logging only the database record for documents, which doesn't include the body content (stored in a separate markdown file). 2. **Server side** (server/routes/sync.py:912-942, 1080-1102): The sync route's _apply_create and _apply_update functions for documents only stored metadata without writing the body to file. ### Changes Made **client/store.py (lines 365-376)** - Modified _log_sync_change to detect document create/update operations - Reads body content from the document file (at base_dir/path) and includes it in sync data - Handles missing files gracefully (logs warning, continues without body) **server/routes/sync.py (lines 923-929)** - Modified _apply_create for documents to write body to file after creating the record - Creates parent directories as needed and writes body content **server/routes/sync.py (lines 1082-1091)** - Modified _apply_update for documents to extract body from filtered_data before passing to store.update_document() - Body is then written to file if provided ### Tests Added **tests/test_sync_log.py (TestDocumentBodySyncLog class)** - test_create_document_includes_body_in_sync_log: Verifies body is included in sync_log for new documents - test_update_document_includes_body_in_sync_log: Verifies updated body is included in sync_log - test_document_without_file_syncs_without_body: Verifies graceful handling when file doesn't exist **tests/test_sync_e2e.py (TestDocumentBodySyncE2E class)** - test_create_document_with_body_syncs_to_server: End-to-end test for document creation with body - test_update_document_body_syncs_to_server: End-to-end test for document update with body ### Verification - All 5 new tests pass - All 85 sync tests pass - All 30 document CLI tests pass - No regressions detected